1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
|
#include <QWebEngineNewWindowRequest>
#include <QWebEngineProfile>
#include <vector>
#include "testUtils.h"
#include "widgets/BrowserManager.hpp"
class BrowserManagerSpec : public QObject {
Q_OBJECT
class FakeNewWindowRequest : public QWebEngineNewWindowRequest {
public:
FakeNewWindowRequest(DestinationType t, const QRect &r, const QUrl &u,
bool b)
: QWebEngineNewWindowRequest(t, r, u, b, nullptr) {}
};
private slots:
void testInitialState() {
context("when initialized");
it("opens a single tab") {
BrowserManager browserManager;
QCOMPARE(browserManager.webViewCount(), 1);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
browserManager.deleteLater();
}
}
void testCreateNewWebView() {
context("when creating a new background webview without a url");
it("opens new tab url as a background view") {
BrowserManager browserManager;
browserManager.createNewWebView();
QCOMPARE(browserManager.webViewCount(), 2);
std::vector<QUrl> urls = {QUrl(BrowserManager::NewtabURL),
QUrl(BrowserManager::NewtabURL)};
QCOMPARE(browserManager.webViewUrls(), urls);
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
context("when creating a new webview with a url and focus is false");
it("opens the given url in background") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("https://duckduckgo.com"), false);
QCOMPARE(browserManager.webViewCount(), 2);
std::vector<QUrl> urls = {QUrl(BrowserManager::NewtabURL),
QUrl("https://duckduckgo.com")};
QCOMPARE(browserManager.webViewUrls(), urls);
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
context("when creating a new webview with a url and focus is true");
it("opens the given url as current view") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("https://duckduckgo.com"), true);
QCOMPARE(browserManager.webViewCount(), 2);
std::vector<QUrl> urls = {QUrl(BrowserManager::NewtabURL),
QUrl("https://duckduckgo.com")};
QCOMPARE(browserManager.webViewUrls(), urls);
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("https://duckduckgo.com"));
}
}
void testNextNavigation() {
context("when nextWebView is called");
context("- and there is only 1 tab");
it("does nothing") {
BrowserManager browserManager;
browserManager.nextWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
context("when nextWebView is called");
context("- and there are tabs after the current tab");
it("goes to the next tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("http://a1.com"));
browserManager.createNewWebView(QUrl("http://a2.com"));
browserManager.nextWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("http://a1.com"));
}
context("when nextWebView is called");
context("- and current tab is the last tab");
it("jumps to the first tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("http://a1.com"));
browserManager.createNewWebView(QUrl("http://a2.com"), true);
QCOMPARE(browserManager.currentWebViewIndex(), 2);
browserManager.nextWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
}
void testPreviousNavigation() {
context("when previousWebView is called");
context("- and there is only 1 tab");
it("does nothing") {
BrowserManager browserManager;
browserManager.previousWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
context("when previousWebView is called");
context("- and there are tabs before the current tab");
it("goes to the next tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("http://a1.com"));
browserManager.createNewWebView(QUrl("http://a2.com"), true);
QCOMPARE(browserManager.currentWebViewIndex(), 2);
browserManager.previousWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("http://a1.com"));
}
context("when previousWebView is called");
context("- and current tab is the last tab");
it("jumps to the last tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("http://a1.com"));
browserManager.createNewWebView(QUrl("http://a2.com"));
browserManager.previousWebView();
QCOMPARE(browserManager.currentWebViewIndex(), 2);
QCOMPARE(browserManager.currentUrl(), QUrl("http://a2.com"));
}
}
void testCloseWebView() {
context("when closeWebView is called");
context("- with out of bounds index");
it("does nothing") {
BrowserManager browserManager;
browserManager.setCurrentUrl(QUrl("https://a.com"));
browserManager.closeWebView(1);
QCOMPARE(browserManager.webViewCount(), 1);
QCOMPARE(browserManager.webViewUrls(),
(std::vector<QUrl>{QUrl("https://a.com")}));
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), QUrl("https://a.com"));
}
context("when closeWebView is called");
context("- and there is only 1 tab");
it("closes the tab and opens empty tab in its place") {
BrowserManager browserManager;
browserManager.setCurrentUrl(QUrl("https://a.com"));
QCOMPARE(browserManager.webViewCount(), 1);
browserManager.closeWebView(0);
QCOMPARE(browserManager.webViewCount(), 1);
QCOMPARE(browserManager.webViewUrls(),
(std::vector<QUrl>{BrowserManager::NewtabURL}));
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), BrowserManager::NewtabURL);
}
context("when closeWebView is called");
context("- with the current tab index");
context("- and there are some tabs after");
it("closes the tab and focuses the next tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("https://a1.com"), true);
browserManager.createNewWebView(QUrl("https://a2.com"));
QCOMPARE(browserManager.webViewCount(), 3);
QCOMPARE(browserManager.currentWebViewIndex(), 1);
browserManager.closeWebView(1);
QCOMPARE(browserManager.webViewCount(), 2);
QCOMPARE(browserManager.webViewUrls(),
(std::vector<QUrl>{BrowserManager::NewtabURL,
QUrl("https://a2.com")}));
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("https://a2.com"));
}
context("when closeWebView is called");
context("- with the current tab index");
context("- which is the last tab");
it("closes the tab and focusses previous tab") {
BrowserManager browserManager;
browserManager.createNewWebView(QUrl("https://a1.com"));
browserManager.createNewWebView(QUrl("https://a2.com"), true);
QCOMPARE(browserManager.webViewCount(), 3);
QCOMPARE(browserManager.currentWebViewIndex(), 2);
browserManager.closeWebView(2);
QCOMPARE(browserManager.webViewCount(), 2);
QCOMPARE(browserManager.webViewUrls(),
(std::vector<QUrl>{BrowserManager::NewtabURL,
QUrl("https://a1.com")}));
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("https://a1.com"));
}
}
void testNewWindowRequestSignal() {
context("when webview emits a newWindowRequested signal");
context("- of type new tab");
it("opens a new web view and focusses it") {
BrowserManager browserManager;
browserManager.setCurrentUrl(QUrl("https://a.com"));
auto webview = browserManager.findChild<QWebEngineView *>();
FakeNewWindowRequest windowRequest(
FakeNewWindowRequest::DestinationType::InNewTab, QRect(0, 0, 0, 0),
QUrl("https://new.com"), true);
emit webview->page()->newWindowRequested(windowRequest);
QCOMPARE(browserManager.webViewCount(), 2);
QCOMPARE(
browserManager.webViewUrls(),
(std::vector<QUrl>{QUrl("https://a.com"), QUrl("https://new.com")}));
QCOMPARE(browserManager.currentWebViewIndex(), 1);
QCOMPARE(browserManager.currentUrl(), QUrl("https://new.com"));
}
context("when webview emits a newWindowRequested signal");
context("- of type new background tab");
it("opens a new web view in the background") {
BrowserManager browserManager;
browserManager.setCurrentUrl(QUrl("https://a.com"));
auto webview = browserManager.findChild<QWebEngineView *>();
FakeNewWindowRequest windowRequest(
FakeNewWindowRequest::DestinationType::InNewBackgroundTab,
QRect(0, 0, 0, 0), QUrl("https://new.com"), true);
emit webview->page()->newWindowRequested(windowRequest);
QCOMPARE(browserManager.webViewCount(), 2);
QCOMPARE(
browserManager.webViewUrls(),
(std::vector<QUrl>{QUrl("https://a.com"), QUrl("https://new.com")}));
QCOMPARE(browserManager.currentWebViewIndex(), 0);
QCOMPARE(browserManager.currentUrl(), QUrl("https://a.com"));
}
}
};
QTEST_REGISTER(BrowserManagerSpec)
#include "BrowserManagerSpec.moc"
|
