Add events system for lua runtime to dispatch and register events

2 files changed, 9 insertions, 8 deletions

diff --git a/src/widgets/BrowserApp.cpp b/src/widgets/BrowserApp.cpp
index f2d541d..d65a122 100644
--- a/src/widgets/BrowserApp.cpp
+++ b/src/widgets/BrowserApp.cpp
@@ -11,8 +11,7 @@ BrowserApp::BrowserApp() {
   lua.start_event_loop();
 
   // Router init
-  auto &router = WindowActionRouter::instance();
-  router.initialize();
+  WindowActionRouter::instance().initialize();
 
   // Global event filter
   qApp->installEventFilter(this);
@@ -22,14 +21,15 @@ BrowserApp::BrowserApp() {
 };
 
 BrowserWindow *BrowserApp::create_window() {
-  auto *win = new BrowserWindow((const Configuration &)configuration);
-  win->setWindowTitle("null-browser");
-  WindowActionRouter::instance().add_window(win);
-  win->show();
-  return win;
+  auto *window = new BrowserWindow((const Configuration &)configuration);
+  window->setWindowTitle("null-browser");
+  WindowActionRouter::instance().add_window(window);
+  window->show();
+  return window;
 }
 
 bool BrowserApp::eventFilter(QObject *target, QEvent *event) {
+  // TODO: Prevent key release and shortcut on mode too
   if (event->type() != QEvent::KeyPress)
     return false;
 
diff --git a/src/widgets/BrowserWindow.hpp b/src/widgets/BrowserWindow.hpp
index 9aeeda3..4865ec9 100644
--- a/src/widgets/BrowserWindow.hpp
+++ b/src/widgets/BrowserWindow.hpp
@@ -6,7 +6,7 @@
 #include "WindowMediator.hpp"
 #include "utils.hpp"
 
-using WindowId = uint64_t;
+using WindowId = qsizetype;
 
 class BrowserWindow : public QMainWindow {
   Q_OBJECT
@@ -24,6 +24,7 @@ public:
 
 signals:
   void closed();
+  // void new_window_requested(const QUrl &url);
 
 private:
   WindowMediator *win_mediator;