From c999d5703d22a7b73394b50029ceede4ef06f09c Mon Sep 17 00:00:00 2001
From: Akshay Nair <phenax5@gmail.com>
Date: Sun, 5 Oct 2025 10:51:54 +0530
Subject: Handle non-zero exit codes in commands

---
 lib/Daffm/Action/Commands.hs | 47 +++++++++++++++++++++++++++++---------------
 1 file changed, 31 insertions(+), 16 deletions(-)

(limited to 'lib/Daffm/Action/Commands.hs')

diff --git a/lib/Daffm/Action/Commands.hs b/lib/Daffm/Action/Commands.hs
index 91e21b6..e904bf5 100644
--- a/lib/Daffm/Action/Commands.hs
+++ b/lib/Daffm/Action/Commands.hs
@@ -17,7 +17,15 @@ import Data.Char (isSpace)
 import Data.Maybe (fromMaybe)
 import qualified Data.Set as Set
 import qualified Data.Text as Text
-import System.Process (callCommand)
+import qualified GHC.IO.Exception as Proc
+import System.Exit (ExitCode)
+import qualified System.Process as Proc
+
+runCmdline :: AppEvent ()
+runCmdline = do
+  cmd <- getCmdlineText
+  leaveCmdline
+  evaluateCommand cmd
 
 parseCommand :: Text.Text -> Maybe Command
 parseCommand (Text.splitAt 2 -> ("!!", cmd)) = Just $ CmdShell True cmd
@@ -43,16 +51,23 @@ parseCommand cmd = mkCmd . splitCmdArgs $ trimStart cmd
       ("selection-clear", _) -> Just CmdClearSelection
       _ -> Nothing
 
-processCommand :: Command -> AppEvent ()
-processCommand (CmdShell True cmd) = do
-  cmd' <- Text.unpack <$> cmdSubstitutions cmd
+-- Suspend tui and run shell command
+-- When waitForKey is true, it will prompt for a key press on success
+-- When exit code is non-zero, it will print it and prompt for key press regardless of waitForKey
+suspendAndRunShellCommand :: Bool -> Text.Text -> AppEvent ()
+suspendAndRunShellCommand waitForKey cmd = do
   suspendAndResume' $ do
-    callCommand cmd'
-    putStrLn "Press any key to continue" >> void getChar
-  reloadDir
-processCommand (CmdShell False cmd) = do
-  cmd' <- Text.unpack <$> cmdSubstitutions cmd
-  suspendAndResume' $ callCommand cmd'
+    exitCode <- shellCommand $ Text.unpack cmd
+    case exitCode of
+      Proc.ExitFailure code -> do
+        putStrLn $ "Process exited with " <> show code
+        putStrLn "Press any key to continue" >> void getChar
+      _ | waitForKey -> putStrLn "Press any key to continue" >> void getChar
+      _ -> pure ()
+
+processCommand :: Command -> AppEvent ()
+processCommand (CmdShell waitForKey cmd) = do
+  cmdSubstitutions cmd >>= suspendAndRunShellCommand waitForKey
   reloadDir
 processCommand CmdQuit = M.halt
 processCommand (CmdSetCmdline txt) = enterCmdline >> setCmdlineText txt
@@ -66,6 +81,12 @@ processCommand CmdClearSelection = clearFileSelections
 processCommand CmdGoBack = goBackToParentDir
 processCommand CmdNoop = pure ()
 
+shellCommand :: String -> IO ExitCode
+shellCommand cmd = do
+  Proc.withCreateProcess
+    (Proc.shell cmd) {Proc.delegate_ctlc = True}
+    $ \_ _ _ p -> Proc.waitForProcess p
+
 cmdSubstitutions :: Text.Text -> AppEvent Text.Text
 cmdSubstitutions cmd = do
   (AppState {stateFiles, stateCwd, stateFileSelections}) <- get
@@ -82,12 +103,6 @@ cmdSubstitutions cmd = do
           . Text.replace "%F" (Text.dropWhileEnd (== '\n') $ Text.unlines selectionsOrCurrent)
   pure . subst $ cmd
 
-runCmdline :: AppEvent ()
-runCmdline = do
-  cmd <- getCmdlineText
-  leaveCmdline
-  evaluateCommand cmd
-
 evaluateCommand :: Text.Text -> AppEvent ()
 evaluateCommand cmdtxt =
   case parseCommand cmdtxt of
-- 
cgit v1.3.1